[Improvement] Add placeholder for failed test without message field#1940
Merged
alexjustesen merged 2 commits intoalexjustesen:mainfrom Dec 19, 2024
Merged
Conversation
alexjustesen
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Sometimes, the Ookla CLI fails to execute the test due to an unknown error. Unfortunately, in such cases, the CLI does not return a complete JSON error response. Instead, it only provides:
Our current logic expects a complete JSON response containing a
messagefield. This PR introduces a placeholder error message for these cases, ensuring that failed tests are not left without an error message.As we cannot do anything about the reason of the failure this;
🪵 Changelog
➕ Added
messagefield.